Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / SelectedAccountController (PART 1) #1081

Merged
merged 9 commits into from
Nov 11, 2024
Merged

Feature / SelectedAccountController (PART 1) #1081

merged 9 commits into from
Nov 11, 2024

Conversation

sonytooo
Copy link
Collaborator

@sonytooo sonytooo commented Nov 8, 2024 •
edited
Loading

  • Introduced a new ctrl called: SelectedAccountController
  • Init SelectedAccountController into the MainController
  • selectAccount logic moved from the AccountsController to the MainController

Instead of accessing the account address via mainCtrl.accounts.selectedAccount, you can now directly access it through mainCtrl.selectedAccount.account.addr and other respective properties within mainCtrl.selectedAccount.account

@sonytooo sonytooo added enhancement New feature or request refactoring labels Nov 8, 2024
@sonytooo sonytooo self-assigned this Nov 8, 2024
@sonytooo sonytooo marked this pull request as ready for review November 11, 2024 10:04
@sonytooo sonytooo changed the title Feature / SelectedAccountController Feature / SelectedAccountController (PART 1) Nov 11, 2024
@PetromirDev PetromirDev self-requested a review November 11, 2024 13:14
PetromirDev
PetromirDev requested changes Nov 11, 2024
View reviewed changes
src/controllers/accounts/accounts.ts Outdated Show resolved Hide resolved
@sonytooo sonytooo merged commit 9b2d221 into v2 Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetromirDev PetromirDev PetromirDev requested changes

Assignees

@sonytooo sonytooo

Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonytooo @PetromirDev