Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dappname to call structure #983

Draft
wants to merge 1 commit into
base: humanizer-remove-async-ops
Choose a base branch
from
Draft

Add dappname to call structure #983

wants to merge 1 commit into from

Conversation

JIOjosBG
Copy link
Member

@JIOjosBG JIOjosBG commented Sep 2, 2024

@JIOjosBG JIOjosBG added the enhancement New feature or request label Sep 2, 2024
@JIOjosBG JIOjosBG self-assigned this Sep 2, 2024
Ivshti
Ivshti requested changes Sep 15, 2024
View reviewed changes
src/libs/main/main.ts
fromUserRequestId: userRequest.id,
meta: {
dapp: {
name: userRequest?.dappPromise?.session?.name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems wrong to put so many ? here, this is operator abuse. At least userREquest must be present.

@Ivshti
Copy link
Member

Ivshti commented Oct 27, 2024

@JIOjosBG is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivshti Ivshti Ivshti requested changes

Assignees

@JIOjosBG JIOjosBG

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JIOjosBG @Ivshti