Add account_id to requests - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select the correct claim (this is different for Keycloak vs.Entra) to extract the email address of the user who made the request. This is then added to the request as 'account_id' property. For system accounts, select the app id. If none of the above are present, extract the 'sub' claim as account_id
Note: Er wordt in de tests nog aangenomen dat de
subclaim een e-mail adres bevat, maar zowel Keycloak als Entra tokens is het een token. Desubclaim wordt wel aangeraden om een user mee te identificeren:https://learn.microsoft.com/en-us/entra/identity-platform/id-token-claims-reference#use-claims-to-reliably-identify-a-user
Maar dat is out of scope voor deze PR lijkt me?