Draft
Conversation
* feat: enable proxy usage * build(release): file w/ tag * build(Make): re-add node versions * build(xdebug): client host * feat: missing files :-) * feat: make import schuldeisers command working from local * build(make): add command to enter pod * refactor(allegro): move duplicate code to helper function * feat(allegro): implement proxy in more services * refactor(allegro): make it more DRY * refactor(allegrohelper): make code more consistent * build(docker): pull and restart policies * chore(cleanup): unused imports and spacing --------- Co-authored-by: jmassink <j.massink@amsterdam.nl>
…ossier into release/SCHUL_sprint-7
* build(release): file w/ tag * build(Make): re-add node versions * build(xdebug): client host * build(deps): composer upgrade * build(deps): npm update * build(deps): bump webpack-dev-server from 4.15.2 to removed in the npm_and_yarn group across 1 directory (#372) * build(deps): bump webpack-dev-server Bumps the npm_and_yarn group with 1 update in the / directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Removes `webpack-dev-server` --- updated-dependencies: - dependency-name: webpack-dev-server dependency-version: dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): upgrade symfony webpack encore And related pacakges. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ruben Sibon <r.sibon@amsterdam.nl> * build(deps): upgrade jspdf majorly --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ossier into release/SCHUL_sprint-7
style(editorconfig): update linelength
feat(dossierDasboard.html.twig): don't show export button to normal users
This PR adds an additional file action button for pdf files. This button opens a pdf inside the browser in a new tab. This button is only visible for PDF files HTML and CSS architecture is refactored. Instead of nested div with relative and absolut positions, the buttons are nested files action list container, which works with flexbox The CSS is made a bit more DRY by introducing mixin's and variables A new 'full-screen' icon is added
feat(db): drop legacy thumbnail table
--------- Co-authored-by: jmassink <j.massink@amsterdam.nl>
* chore: remove momentjs; update lockfiles * fix: recreate vendor dir Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: remove redundant postinstall script --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares a Sprint 8 release (v8.2.0) that introduces a new feature for viewing PDF documents in fullscreen mode in a new tab, along with dependency updates and code cleanup.
Changes:
- Added fullscreen viewing capability for PDF documents with new UI buttons and styling
- Updated package dependencies (jspdf, sass-loader, webpack-encore) and removed moment.js dependency
- Refactored Allegro service integration to support proxy configuration
- Cleaned up legacy code including thumbnail database table migration and commented-out code
Reviewed changes
Copilot reviewed 27 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version_file | Updated version to v8.2.0 for Sprint 8 release |
| templates/partial.files-list.html.twig | Restructured document action buttons to include fullscreen view option for PDFs |
| templates/master.html.twig | Removed moment.js script tags |
| templates/UserReleaseNotes/26-02-03/*.html.twig | Added release notes for v8.2.0 feature |
| templates/Dossier/partial.dossierDashboard.html.twig | Restricted Allegro export button to ROLE_ADMIN only |
| templates/Dossier/index.html.twig | Updated announcement banner for new PDF fullscreen feature |
| src/Service/AllegroService.php | Added proxy configuration support and refactored for code formatting |
| src/Migrations/Version20260123132537.php | Created migration to drop legacy thumbnail table and rename indexes |
| src/Controller/AllegroController.php | Removed commented-out code |
| src/Allegro/*.php | Refactored factory classes to support proxy configuration using new helper |
| package.json | Updated dependencies and removed moment.js |
| organisaties.json | Added new organization "Doras" |
| docker-phpfpm/xdebug.ini | Updated xdebug configuration |
| docker-compose*.yml | Removed version specification and updated proxy service configuration |
| config/services.yaml | Added proxy host and port parameters |
| composer.json | Removed moment.js dependency |
| assets/scss/partials/_*.scss | Added fullscreen icon styles and refactored document action button styling |
| Makefile | Updated Node docker image version and added kubectl command |
| Dockerfile_* | Removed npm postinstall commands and updated xdebug version |
| .editorconfig | Added new editor configuration file |
Comments suppressed due to low confidence (1)
assets/scss/partials/_document.scss:1
- The line contains trailing whitespace that should be removed.
$fileIconHeight: 150px;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <h3>Nieuw</h3> | ||
|
|
||
| <h4>PDF-documenten zijn op volledig scherm te bekijken in een nieuw tabblad.</h4> | ||
| <p>In de lijst met documenten is voor elk document van het type "PDF" een knop toegevoegd. Als je op deze knop drukt wordt het document ge-opend in een nieuw tabblad. Deze knop is te vinden tussen de verwijder- en downloadknop en is herkenbaar aan dit icoon: <i class="icon-fullscreen"></i> |
There was a problem hiding this comment.
Corrected hyphenation of 'ge-opend' to 'geopend'
Suggested change
| <p>In de lijst met documenten is voor elk document van het type "PDF" een knop toegevoegd. Als je op deze knop drukt wordt het document ge-opend in een nieuw tabblad. Deze knop is te vinden tussen de verwijder- en downloadknop en is herkenbaar aan dit icoon: <i class="icon-fullscreen"></i> | |
| <p>In de lijst met documenten is voor elk document van het type "PDF" een knop toegevoegd. Als je op deze knop drukt wordt het document geopend in een nieuw tabblad. Deze knop is te vinden tussen de verwijder- en downloadknop en is herkenbaar aan dit icoon: <i class="icon-fullscreen"></i> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft until we are ready to deploy a release.