fix(SCHUL-733): Proxy var names#390
fix(SCHUL-733): Proxy var names#390RubenSibon wants to merge 1 commit intorelease/SCHUL_sprint-8from
Conversation
RubenSibon
requested review from
Copilot,
jmassink and
tvanoort85
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR fixes proxy variable naming inconsistencies throughout the codebase by renaming proxy-related parameters to better reflect their purpose.
Changes:
- Renamed
$proxyPortto$proxyHostPortacross service classes and factories to indicate it represents a port associated with a proxy host - Updated parameter names in method signatures, property declarations, and documentation comments
- Updated service configuration binding to match the new parameter name
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Service/AllegroService.php | Updated constructor parameter, property name, and method parameters from $proxyPort to $proxyHostPort |
| src/Allegro/SchuldHulpClientFactory.php | Renamed factory method parameters to use $proxyHostIp and $proxyHostPort |
| src/Allegro/LoginClientFactory.php | Renamed factory method parameters to use $proxyHostIp and $proxyHostPort |
| src/Allegro/AllegroHelper.php | Updated method parameters and documentation to use $proxyHostIp and $proxyHostPort |
| config/services.yaml | Updated service binding from $proxyPort to $proxyPortPort |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RubenSibon
force-pushed
the
fix/SCHUL-773_proxy-vars
branch
2 times, most recently
from
c21bee8 to
352a8b1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RubenSibon
force-pushed
the
fix/SCHUL-773_proxy-vars
branch
from
352a8b1 to
518a185
Compare
RubenSibon
force-pushed
the
fix/SCHUL-773_proxy-vars
branch
from
518a185 to
1aa92dc
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jmassink
left a comment
jmassink
left a comment
There was a problem hiding this comment.
The base vervangen naar release sprint 8
2 participants
No description provided.