added lambda interpreter solution & excersizes solutions by AnNyiiik · Pull Request #3 · AnNyiiik/FSharpCourse

AnNyiiik · 2024-03-29T13:15:00Z

No description provided.

YuriUfimtsev · 2024-04-23T13:20:58Z

lambda_calculus.tex

+\begin{math}((\lambda a. (\lambda b.b \ b) \ (\lambda b.b \ b))\ b)\ ((\lambda c.(c\ b)) \ (\lambda a. a)) \ \rightarrow_{\beta} ((\lambda b.b \ b) \ (\lambda b.b \ b)) \ ((\lambda c.(c\ b)) \ (\lambda a. a)) \rightarrow_{\beta} ((\lambda b.b \ b) \ (\lambda b.b \ b)) ((\lambda a. a) \ b) \ \rightarrow_{\beta} ((\lambda b.b \ b) \ (\lambda b.b \ b)) \ b
+\section{SKK}
+\begin{math}((\lambda x\ y\ z.x\ z\ (y\ z))\  (\lambda x\ y . x))\ (\lambda x\ y . x)\  \rightarrow_{\alpha} ((\lambda x\ y\ z.x\ z\ (y\ z))\  (\lambda a\ b . a))\ (\lambda m\ p . m)\  \rightarrow_{\beta} ((\lambda y\ z.(\lambda a \ b.a)\ z\ (y\ z))\ (\lambda m\ p . m)\ \rightarrow_{\beta} \lamda z.(\lambda a \ b.a)\ z \ ((\lamda m\ p. m)\ z)) \ \rightarrow{\beta} \lambda z.z\end{math}
+\end{document}


Компилится с ошибками, стоит от них избавиться.
И в SKK чем дальше, тем хуже форматирование: пропали некоторые лямбды, символы betta-редукции увеличиваются. Надо привести в читабельный вид, чтобы каждый новый терм после применения правила оказывался на новой строке

yurii-litvinov · 2024-05-31T17:00:25Z

Lambda_Interpreter/LambdaInterpreter.Tests/Program.fs

+module Program =
+
+    [<EntryPoint>]
+    let main _ = 0


Я предпочитаю это не писать, а делать GenerateProgramFile>true</GenerateProgramFile>

yurii-litvinov · 2024-05-31T17:00:46Z

Lambda_Interpreter/LambdaInterpreter.Tests/UnitTests.fs

+[<Test>]
+let Test1 () =
+    Assert.Pass()
+


yurii-litvinov · 2024-05-31T17:00:56Z

Lambda_Interpreter/Lambda_Interpreter.Tests/Lambda_Interpreter.Tests.fsproj

+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net7.0</TargetFramework>


net7.0 помер давно

yurii-litvinov · 2024-05-31T17:01:28Z

Lambda_Interpreter/Lambda_Interpreter.Tests/Program.fs

+module Program =
+
+    [<EntryPoint>]
+    let main _ = 0


Где-то я это уже видел

yurii-litvinov · 2024-05-31T17:02:20Z

Lambda_Interpreter/Lambda_Interpreter.Tests/UnitTests.fs

+    Assert.AreEqual(expected, result)
+[<Test>]


Suggested change

Assert.AreEqual(expected, result)

[<Test>]

Assert.AreEqual(expected, result)

[<Test>]

И ниже.

yurii-litvinov · 2024-05-31T17:02:38Z

Lambda_Interpreter/Lambda_Interpreter/LambdaInterpreter.fs

@@ -0,0 +1,63 @@
+namespace Lambda_Interpreter
+
+module lambdaInterpreter = 


Надо комментарии

yurii-litvinov · 2024-05-31T17:13:15Z

Lambda_Interpreter/Lambda_Interpreter/LambdaInterpreter.fs

+        | Abstraction of string * LambdaTerm
+        | Application of LambdaTerm * LambdaTerm
+
+    type Substitution = (string * LambdaTerm) list


yurii-litvinov · 2024-05-31T19:17:11Z

Lambda_Interpreter/Lambda_Interpreter/LambdaInterpreter.fs

+        | Variable name ->
+            if List.contains name boundVariables then
+                let newName = name + "'"
+                Variable newName


А почему newName не может быть в boundVariables?

yurii-litvinov · 2024-05-31T19:20:26Z

Lambda_Interpreter/Lambda_Interpreter/LambdaInterpreter.fs

+        | Variable _ -> term
+        | Abstraction (arg, body) -> Abstraction (arg, betaReduce body)
+        | Application (Abstraction (arg, body), argValue) ->
+            let substitutedBody = substitute [(arg, argValue)] body


Я так и не понял, зачем substitute список принимает

yurii-litvinov · 2024-05-31T19:21:04Z

Lambda_Interpreter/Lambda_Interpreter/LambdaInterpreter.fs

+        match term with
+        | Variable name -> name
+        | Abstraction (arg, body) -> sprintf "(λ%s.%s)" arg (toString body)
+        | Application (func, arg) -> sprintf "(%s %s)" (toString func) (toString arg)


CI ругается, что main-а нет. Собирали бы библиотеку, не ругался бы

HW_3/HW_3.Tests/UnitTests.fs

+open HW_3.LambdaInterpreter
+
+[<Test>]
+let ``isFreeVariable: check free variable`` () =


yurii-litvinov · 2024-06-01T19:11:56Z

HW_3/HW_3/LambdaInterpreter.fs

+        | Variable v ->
+            if v = variable then
+                if not (isFreeVariable v value) then
+                    let newName = v + "'" 


А правда ли, что newName гарантированно не входит свободно в value? Тут и ниже.

HW_3/HW_3/LambdaInterpreter.fs

@@ -0,0 +1,80 @@
+namespace HW_3
+
+module LambdaInterpreter =


HW_3/HW_3/LambdaInterpreter.fs

+        | Abstraction of string * LambdaTerm
+        | Application of LambdaTerm * LambdaTerm
+
+


yurii-litvinov · 2024-06-01T19:12:55Z

HW_3/HW_3.Tests/UnitTests.fs

+
+    let expr = 
+        Application (
+            Abstraction ("x", (Abstraction("y", Application( Variable "x", Variable "y")))),


Пробелы неконсистентно расставлены

Не исправлено

yurii-litvinov · 2024-06-01T19:13:24Z

HW_3/HW_3/LambdaInterpreter.fs

+
+
+    let isFreeVariable (variable: string) (expression: LambdaTerm) : bool =
+        let rec isFreeVariableReq (variable: string) (bounded : string list) (expression: LambdaTerm) : bool =


yurii-litvinov · 2024-06-01T19:16:03Z

HW_3/HW_3/LambdaInterpreter.fs

+            if v = oldName then Variable newName else term
+        | Abstraction (v, body) ->
+            if v = oldName then
+                if (isFreeVariable newName body) then


Тут скобки лишние

HW_3/HW_3/LambdaInterpreter.fs

+                if (isFreeVariable newName body) then
+                    Abstraction (newName, alphaConvert oldName newName body)
+                else
+                    Abstraction (v, body)


yurii-litvinov · 2024-06-01T19:18:09Z

HW_3/HW_3/LambdaInterpreter.fs

+        | Abstraction (v, body) ->
+            if v = variable then
+                Abstraction (v, body) 
+            elif not(isFreeVariable v value) then


Suggested change

elif not(isFreeVariable v value) then

elif not (isFreeVariable v value) then

Скобки в F# не ограничивают список параметров, а обозначают границы одного параметра, так что с пробелом

И почему not? Если переменная под лямбдой не входит свободно в подставляемый терм, её как раз можно не трогать, она ничего там не свяжет. В определении подстановки не так было

yurii-litvinov

Идеологически всё так, но оооочень неаккуратно

yurii-litvinov · 2024-09-21T10:18:17Z

HW_3/HW_3.Tests/HW_3.Tests.fsproj

+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net7.0</TargetFramework>


На .NET 8 так и не удалось мигрировать? IRL Вы могли бы оказаться в забавной ситуации, когда Вы начинаете деплой в инфраструктуре заказчика, а там рантайм только .NET 8 и нет возможности сказать .NET 7 (например, по политикам безопасности). И программа вообще не запускается. И заказчик такой "Ну вот же, замечания с первой приёмки, целевую платформу поменять, почему не сделали?". И срыв приёмо-сдаточных испытаний, неустойка, позорное увольнение.

yurii-litvinov · 2024-09-21T14:35:46Z

HW_3/HW_3.Tests/UnitTests.fs

+
+    let expr = 
+        Application (
+            Abstraction ("x", (Abstraction("y", Application( Variable "x", Variable "y")))),


Не исправлено

yurii-litvinov · 2024-09-21T14:37:57Z

HW_3/HW_3/LambdaInterpreter.fs

+
+module LambdaInterpreter =
+
+    /// <summary>The type which expresses the lambda-term.</summary>


В F#, кстати, более принято просто /// The type which expresses the lambda-term., без тэгов, где они не нужны.

yurii-litvinov · 2024-09-21T14:41:01Z

HW_3/HW_3/LambdaInterpreter.fs

+    /// <param name="variable">The variable name.</param>
+    ///<param name="expression">The lambda-term of an expression.</param>


Тут то есть пробел после ///, то нет

yurii-litvinov · 2024-09-21T14:41:43Z

HW_3/HW_3/LambdaInterpreter.fs

+    /// <param name="variable">The variable name.</param>
+    ///<param name="expression">The lambda-term of an expression.</param>
+    ///<returns>The truth if the variable is in the expression, otherwise false.</returns>
+    let rec isVaraibleInExpression (variable: string) (expression: LambdaTerm) : bool =


Опечатка в названии

yurii-litvinov · 2024-09-21T14:43:26Z

HW_3/HW_3/LambdaInterpreter.fs

+    ///<param name="expression">The lambda-term of an expression.</param>
+    ///<returns>The truth if the variable is bounded, otherwise false.</returns>
+    let isFreeVariable (variable: string) (expression: LambdaTerm) : bool =
+        let rec isFreeVariableRec (variable: string) (bounded : string list) (expression: LambdaTerm): bool =


bounded ("ограниченный") лучше переименовать в bound ("связанный")

yurii-litvinov · 2024-09-21T14:48:07Z

HW_3/HW_3/LambdaInterpreter.fs

+        | Application (e1, e2) -> 
+            Application (substitute variable value e1, substitute variable value e2)
+
+    ///<summary>Performes a one step of beta-reduction.</summary>


yurii-litvinov

Мелкие замечания остались, но Вы смогли победить переход на .NET 8 с CI, так что зачтена

yurii-litvinov · 2024-09-23T18:51:57Z

HW_3/HW_3.Tests/UnitTests.fs

+    let expr = 
+        Application (
+            Abstraction ("x",
+                (Abstraction("y", Application( Variable "x", Variable "y")))),


Ну так и всё равно тут скобка с пробелом местами поменяны

yurii-litvinov · 2024-09-23T18:52:31Z

HW_3/HW_3/LambdaInterpreter.fs

+
+module LambdaInterpreter =
+
+    ///The type which expresses the lambda-term.


У Вас был выбор, либо вставить пробел везде, либо удалить везде. Вы выбрали неправильно (ну, не по стайлгайду) :)

AnNyiiik added 4 commits March 29, 2024 16:14

added lambda interpreter solution & excersizes solutions

8be2c76

deleted Program.fs

e7ab981

added tests

3f1313c

added tests

d0726eb

YuriUfimtsev reviewed Apr 23, 2024

View reviewed changes

changed tex

34ff2e6

yurii-litvinov suggested changes May 31, 2024

View reviewed changes

AnNyiiik added 4 commits June 1, 2024 18:29

changed lambda interpreter

8f1c01e

changed solution

0b8575e

changed fsproj

60b7aca

deleted Program.fs

8f3cd89

yurii-litvinov suggested changes Jun 1, 2024

View reviewed changes

AnNyiiik added 3 commits September 19, 2024 22:09

changed solution and .net version

7cde8d5

changed .net version

af71a51

added spaces in lines

3d87345

yurii-litvinov suggested changes Sep 21, 2024

View reviewed changes

AnNyiiik added 3 commits September 23, 2024 14:52

fixed mistakes

4de14e6

changed version

d6c7ba5

changed CI dotnet version

03769d7

yurii-litvinov approved these changes Sep 23, 2024

View reviewed changes

		@@ -0,0 +1,63 @@
		namespace Lambda_Interpreter

		module lambdaInterpreter =

		\| Abstraction of string * LambdaTerm
		\| Application of LambdaTerm * LambdaTerm



		let isFreeVariable (variable: string) (expression: LambdaTerm) : bool =
		let rec isFreeVariableReq (variable: string) (bounded : string list) (expression: LambdaTerm) : bool =

	elif not(isFreeVariable v value) then
	elif not (isFreeVariable v value) then


		module LambdaInterpreter =

		/// <summary>The type which expresses the lambda-term.</summary>

		/// <param name="variable">The variable name.</param>
		///<param name="expression">The lambda-term of an expression.</param>


		module LambdaInterpreter =

		///The type which expresses the lambda-term.

Conversation

AnNyiiik commented Mar 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yurii-litvinov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yurii-litvinov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants