-
Notifications
You must be signed in to change notification settings - Fork 477
Added a lot more snippets for terraform #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks a lot @CsBigDataHub ! However I'm a bit scared of this PR, it's the biggest I've ever seen probably not sure how to tackle it. Out of curiosity, are the terraform scripts auto generated from something? And well there is more than just terraform, could we at least split different things in different PRs by any chance? |
@AndreaCrotti , Terraform snippets are are generated from this source - https://github.com/juliosueiras/vim-terraform-snippets/tree/master/terraform using this ruby gem https://github.com/cartolari/snipmate_to_yas Yes we can split the PR for terrform , docker and GO. I can create different branches from the commit history and create new pull requests. How does that sound? |
Yes @CsBigDataHub splitting it in 3 PRs would be great, would be much easier to deal with. I'm also a bit "worried" about how long it actually takes to load so many snippets, I guess anyone not using terraform would not notice at all, but I never had so many snippets for one mode so I'm not sure exactly how fast it is. |
@AndreaCrotti |
@CsBigDataHub |
No description provided.