Avoid name collisions between hover's buffer names#67
Closed
usfbih8u wants to merge 1 commit into
Closed
Conversation
If you use `lsp hover` multiple times on different identifiers without closing the buffer, as the buffer name keeps being the same, it opens the same buffer again. To avoid the name conflict, the timestamp is appended to the name.
Owner
|
I think the bug is not that it uses the same buffer but that it doesn't update its contents. Although the whole hover system will need to be rewritten anyway when we get built-in overlays (micro-editor/micro#3733) so I'm not too concerned about this issue. |
Contributor
Author
|
In fact, I did not use my tooltip module for hover because I see having multiple splits open at the same time useful. Close the PR if you don't want it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you use
lsp hovermultiple times on different identifiers without closing the buffer, as the buffer name keeps being the same, it opens the same buffer again. To avoid the name conflict, the timestamp is appended to the name.