Skip to content

Conversation

@iamliuzy
Copy link

@iamliuzy iamliuzy commented Sep 12, 2025


name: Add method signatures to request methods
about: Add method signatures to request methods
title: 'Add method signatures to request methods'
labels: ''
assignees: 'iamliuzy'


Copy of #756 due to the closing of it.

Related Issue
#319

Proposed Changes
As the title. Add method signatures to request methods.

Although this does nothing at runtime, it provide auto-complete which is helpful.

If these methods have other uses, please let me know.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

iamliuzy added 2 commits July 9, 2025 09:50
To let Pylance stop warning me that these methods doesn't exist.
@gitnotebooks
Copy link

gitnotebooks bot commented Sep 12, 2025

Review these changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/779

@iamliuzy iamliuzy marked this pull request as ready for review September 13, 2025 16:05
@iamliuzy
Copy link
Author

@jph00 can you review when conveneint?

@jph00
Copy link
Contributor

jph00 commented Nov 24, 2025

The current implementation is pretty verbose and clunky. That's a lot of lines of code with a lot of repetition. Let's keep things neat and concise, and seek general solutions over special cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants