Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt #35

Open
wants to merge 1 commit into
base: release/spring-1.0
Choose a base branch
from

Conversation

michaeljyeates
Copy link

C++ std v20 is needed to compile

Change Description

Change CMAKE_CXX_STANDARD to 20 from 17, it uses std::span which gives this error when using v17

note: ‘std::span’ is only available from C++20 onwards
21 | inline thread_local std::spanstd::byte code_memory_range;

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Sorry, something went wrong.

C++ std v20 is needed to compile
@spoonincode
Copy link
Member

This change has already been made in main, as well as the commit of eos-vm that spring 1.1 is based on. Any reason you are targeting this change for spring 1.0 release branch version of eos-vm? As far as I know this c++17 vs c++20 setting doesn't affect building of spring. And I don't think we'd take a non-critical fix for 1.0.x now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants