Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC: Implement get_call_data, set_call_return_value and get_call_data host functions #1258

Open
wants to merge 17 commits into
base: sync_call_limits
Choose a base branch
from

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Mar 18, 2025

This PR implements the remaining sync call host functions. Basic sync call protocol level functionalities are in place.

Unit test basic_params_return_value_passing shows a complete end to end sync call in WASM code using the host functions in the following steps

  1. making a sync call,
  2. passing arguments,
  3. saving return value,
  4. retrieving return value

Resolves #1215

@linh2931 linh2931 requested review from heifner and spoonincode March 18, 2025 00:00
@spoonincode
Copy link
Member

afaict we aren't enforcing max_sync_call_depth yet even in this PR. It feels like at least one of these PRs should have that enforcement? Since this one is at least enforcing max_sync_call_data_size now

@linh2931
Copy link
Member Author

afaict we aren't enforcing max_sync_call_depth yet even in this PR. It feels like at least one of these PRs should have that enforcement? Since this one is at least enforcing max_sync_call_data_size now

I plan to enforce max_sync_call_depth after the refactor of apply_context is done (#1261, my next task), since that will change code structure. This PR focuses on the three host functions. I will create a task issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants