esphome.yaml: Regularize (whitespace, ordering)#108
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
WalkthroughThe PR updates ESPHome device versioning, OTA/update behavior, and air-quality control logic, and also changes GitHub release-note formatting and workflow triggers/permissions. ChangesESPHome configuration updates
GitHub automation and release config
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adjust ordering of esphome yaml, and regularize whitespace. This commit makes no functional changes, and serves only to reduce the diffs from the base config to the BLE and Factory variants.
6e8334b to
919ab0e
Compare
|
Thanks, appreciate the cleanup. Rebased onto On the Version field: it refers to the |
|
Thanks for being welcoming. Ack about beta. |
Adjust ordering of esphome yaml, and regularize whitespace. This commit makes no functional changes, and serves only to reduce the diffs from the base config to the BLE and Factory variants.
Version: 26.6.10.1
(This is confusing. Obviously a PR should be branched from upstream main, so I don't know if you mean to type that version so you know if it's aged, or ?)
Do you really want people to leave comments? (edit: I see they are omitted in display, but still)
What does this implement/fix?
This commit tidies whitespace and ordering of the esphome yaml files, making no functional changes. The point is to reduce the diffs among the three files, so that people trying to understand them have to juggle less. The two improv sections are now together; even though one is serial and one wifi, they are logically a group in the factory config.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Summary by CodeRabbit
Summary by CodeRabbit