[readme] Replace static image with YouTube embed, update DPS310 to DPS368 - #83
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughReplaced a static badge with a YouTube thumbnail link in README.md and updated the sensor model label from DPS310 to DPS368; manifest line counts adjusted. No exported/public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 3: The README uses a potentially unavailable thumbnail resolution and an
unverified video ID: replace the thumbnail filename maxresdefault.jpg with
hqdefault.jpg in the Markdown image link URL and verify (or correct) the video
ID string "Tqq4Si1y34c" to the intended Apollo AIR-1 video; update the link
target and image URL accordingly and test the resulting link/image in a browser
or GitHub preview to ensure the thumbnail loads and points to the correct video.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
README.md (2)
21-21:⚠️ Potential issue | 🟡 MinorClarify
ESP improvewording to avoid user confusion.The sentence appears to reference ESPHome Improv, but “improve” is ambiguous and the final clause is hard to parse.
✏️ Proposed wording adjustment
-- AIR-1_Factory.yaml: This is the firmware flashed by us on new devices. It contains the components for ESP improve, allowing easy adoption in Home Assistant. When you load the device in ESPHome addon, it will grab the firmware from AIR-1.yaml which no longer has the improve. +- AIR-1_Factory.yaml: This is the firmware flashed by us on new devices. It includes ESPHome Improv components for easier adoption in Home Assistant. When you load the device in the ESPHome add-on, it will use AIR-1.yaml, which no longer includes Improv.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 21, Replace the ambiguous phrase “ESP improve” with the correct name “ESPHome Improv” and rephrase the sentence referencing AIR-1_Factory.yaml and AIR-1.yaml so it reads clearly; update the line describing AIR-1_Factory.yaml to say that it contains firmware flashed on new devices which includes components for ESPHome Improv to ease Home Assistant adoption, and clarify that when loading the device in the ESPHome addon it will instead retrieve firmware from AIR-1.yaml which does not include Improv.
27-27:⚠️ Potential issue | 🟡 MinorFix broken Markdown link syntax for Discord URL.
Line 27 is currently bracketed text, not a clickable Markdown link. Use
[text](url)format.✏️ Proposed fix
-Discord (Support/feedback/discussion/future products): [https://dsc.gg/ApolloAutomation] \ +Discord (Support/feedback/discussion/future products): [https://dsc.gg/ApolloAutomation](https://dsc.gg/ApolloAutomation) \🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 27, Replace the current bracketed URL on the line containing "Discord (Support/feedback/discussion/future products): [https://dsc.gg/ApolloAutomation] \" with a proper Markdown link using the [text](url) format so the Discord entry becomes a clickable link; locate the string "Discord (Support/feedback/discussion/future products)" in README.md and update that line accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@README.md`:
- Line 21: Replace the ambiguous phrase “ESP improve” with the correct name
“ESPHome Improv” and rephrase the sentence referencing AIR-1_Factory.yaml and
AIR-1.yaml so it reads clearly; update the line describing AIR-1_Factory.yaml to
say that it contains firmware flashed on new devices which includes components
for ESPHome Improv to ease Home Assistant adoption, and clarify that when
loading the device in the ESPHome addon it will instead retrieve firmware from
AIR-1.yaml which does not include Improv.
- Line 27: Replace the current bracketed URL on the line containing "Discord
(Support/feedback/discussion/future products): [https://dsc.gg/ApolloAutomation]
\" with a proper Markdown link using the [text](url) format so the Discord entry
becomes a clickable link; locate the string "Discord
(Support/feedback/discussion/future products)" in README.md and update that line
accordingly.
|
|
||
| SEN55: Particulate matter (PM1, PM2.5, PM10), VOCs, NOx, humidity, and temperature. | ||
|
|
||
| DPS310: Barometric air pressure and temperature. |
Member
There was a problem hiding this comment.
Can you update to DPS368, we are going to start shipping them now.
bharvey88
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the static product image with a clickable YouTube thumbnail linking to the product video. Also removes the DPS310 sensor line as it is no longer part of the product.
Summary by CodeRabbit