Repository navigation
Conversation
newer sdcc versions reject empty () prototypes with --Werror
- use (void) for empty function prototypes, rejected by sdcc >= 4.5 - remove unused PIN_MIRROR_NULL enum value that is outside int range - move the PARAM_MAX range check in param_check() into the switch default case, avoiding an sdcc optimizer error on the switch when the range is already known to be checked bootloader binaries are unchanged; radio binaries only change in param_check() code layout
derive the board list from include/rules_*.mk so new boards are built automatically, and fail if any board is missing a firmware or bootloader image
actions/upload-artifact@v3 is deprecated and now fails the job. Move to checkout@v4, upload-artifact@v4 and ubuntu-24.04, add a job timeout, and drop the intelhex pip install which nothing uses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has been failing since GitHub started rejecting jobs that use actions/upload-artifact v3.
This PR:
()prototypes under --Werror and flag an out-of-range enum value and a folded switch bounds check in param_check()Verified all 12 boards build with sdcc 4.0.0 (Ubuntu 22.04), 4.2.0 (Ubuntu 24.04, the CI runner) and 4.5.0. Bootloader binaries are byte-identical to before; radio binaries only differ in the param_check() code layout.