fix: resolve backend issues 1107, 1109, and 1117#1232
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@anoncon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves multiple backend issues related to disputes and global search.
Changes
Fix: Duplicate Dispute Creation (Closes [Backend] — Test:
DisputesService.createallows second dispute after first is resolved #1107)DisputesService.createto verify if a dispute already exists for a market regardless of its status. This enforces the policy of a single dispute per market.disputes.service.spec.ts.Feature: Add
GET /disputes/my(Closes [Backend] — Feature: AddGET /disputes/my— disputes filed by the current user #1109)findMyDisputestoDisputesServiceand its respective test suite.Fix: Global Search Inaccurate Totals (Closes [Backend] — Bug/Test:
SearchService.searchreturns inaccuratetotal#1117)searchMarkets,searchUsers, andsearchCompetitionsinSearchServiceto return[results, count]using TypeORM'sgetManyAndCount().GlobalSearchResponseDtoto exposetotal_markets,total_users, andtotal_competitions.totalnow reflects the true database count rather than the post-slice returned item size.(Note: Issue #1108 regarding
UsersService.findPublicPredictionsByAddressin-memory filtering was verified to already be handled via SQLandWherefilters.)Testing:
All tests have run and passed successfully.
Closes #1108