[Backend] Idempotency keys for prediction submission & other write endpoints#1241
Merged
Merged
Conversation
Introduces an Idempotency-Key mechanism: the first request with a given key for a user executes normally; a later request with the same key and body replays the stored response without re-running the handler. Same key with a different body returns 422, a missing key on an @idempotent() route returns 400, and a concurrent duplicate while the first request is still in flight returns 409. An hourly cron prunes keys older than 24h. Closes Arena1X#1000
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@itodo001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Idempotency-Keyrequest-header mechanism: the first request with a given key for a given user executes normally and its response is stored; a later request with the same key replays the stored response without re-executing the handler.IdempotencyKeyentity +IdempotencyService(acquire/complete/release + hourly cleanup cron for rows older than 24h) undersrc/common/idempotency/.IdempotencyInterceptor+@Idempotent()decorator, applied toPOST /predictions.1776500000000-CreateIdempotencyKeys.tscreating theidempotency_keystable with a unique(key, userId)index and a FK tousers.Behavior
422.Idempotency-Keyheader on an@Idempotent()route →400.409.Files
src/common/idempotency/*(new)src/common/common.module.tssrc/predictions/predictions.controller.tssrc/predictions/predictions.module.tssrc/migrations/1776500000000-CreateIdempotencyKeys.tsCloses #1000