feat(browse): walk content cursor across dialogues - #213
Draft
Ariestar wants to merge 1 commit into
Draft
Conversation
j/k off either end of the shown dialogue's blocks now steps the dialogue list instead of clamping, so one walk covers every dialogue the list holds — across every marked session. Crossing is two-phase: the key handler records a direction, and the redraw lands the cursor on the end of the frame it arrived at, since the next dialogue's blocks only exist once its frame is built. The content pane now always shows the dialogue under the dialogue cursor, which deletes multi-select paging outright: shown_dialogue_idx, the J/K actions and help entries, content_page and its `· 2/3` label, and the markable_key / marks_key redraw guards. Block marks keep their real invariant instead — a mark is meaningful exactly while its dialogue still has a materialized body — as ContentPane::retain_marks beside the projection that decides it.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ariestar
changed the title
Deploying sivtr with
|
| Latest commit: |
3d0799a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://992d81cb.sivtr.pages.dev |
| Branch Preview URL: | https://feat-content-cursor-crosses.sivtr.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
j/k off either end of the shown dialogue's blocks now steps the dialogue
list instead of clamping, so one walk covers every dialogue the list
holds — across every marked session. Crossing is two-phase: the key
handler records a direction, and the redraw lands the cursor on the end
of the frame it arrived at, since the next dialogue's blocks only exist
once its frame is built.
The content pane now always shows the dialogue under the dialogue cursor,
which deletes multi-select paging outright: shown_dialogue_idx, the J/K
actions and help entries, content_page and its
· 2/3label, and themarkable_key / marks_key redraw guards. Block marks keep their real
invariant instead — a mark is meaningful exactly while its dialogue still
has a materialized body — as ContentPane::retain_marks beside the
projection that decides it.
Stack created with GitHub Stacks CLI • Give Feedback 💬