Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timeout option to helper query functions #6834

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

sagarneeldubey
Copy link
Contributor

Add timeout parameter to helper query functions - get_retrieved_documents and get_qa_with_reference. This update allows developers to adjust the timeout value, extending beyond the default 5 seconds for long-running queries. If the timeout parameter is not provided, the previous default behavior of 5 seconds remains unchanged.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 19, 2025
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@mikeldking mikeldking changed the title Add timeout option to helper query functions feat(client): Add timeout option to helper query functions Mar 19, 2025
@mikeldking
Copy link
Contributor

@sagardubey1 makes sense. could you sign the CLA? Will get @Arize-ai/oss-python folks to take a look.

@sagarneeldubey
Copy link
Contributor Author

@mikeldking Thanks and here goes:

I have read the CLA Document and I hereby sign the CLA

@axiomofjoy
Copy link
Contributor

recheck

@mikeldking
Copy link
Contributor

Hey @sagarneeldubey just need an isolated message. Silly bot.

@sagarneeldubey
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mikeldking mikeldking changed the title feat(client): Add timeout option to helper query functions feat: Add timeout option to helper query functions Mar 22, 2025
@mikeldking mikeldking merged commit b383e81 into Arize-ai:main Mar 22, 2025
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants