Skip to content

Conversation

vemacs
Copy link

@vemacs vemacs commented Sep 22, 2014

  • ProtocolLib is unnecessary for determining a player's client version
  • Spigot builds after 0916a add an extra boolean for lighting fix to teleport packets, breaking the constructor, this fixes it
  • Old POM literally shaded in all of Spigot, this only shades in Updater and Metrics-lite
  • Better 1.8 client support by continuously forcing a resend

@calebbfmv
Copy link

10/10 would merge

@harrydevane
Copy link

I wouldnt use the NMS you implemented for the protocol version check, but apart from that looks good.

@vemacs
Copy link
Author

vemacs commented Sep 22, 2014

BarAPI is version dependent anyways, so the NMS doesn't hurt. I do have it implemented with reflection, but given that there won't ever be a new versioned package plus BarAPI is version dependent anyways, it really shouldn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants