Return tool errors for invalid web fetch URLs#61
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
declanjackson
approved these changes
Jul 8, 2026
declanjackson
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just one small comment on the error msg
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolResultwhenfetch_web_pagereceives a non-absolute web URL, such as a local filesystem path.httpxfetch path unchanged for absolutehttp://andhttps://URLs.Backward compatibility
This is backward compatible because the new guard only intercepts inputs that
httpxcannot fetch successfully with the existing default transport: URLs without anhttp/httpsscheme or without a network location. Any absolute HTTP or HTTPS URL still flows through the same_fetchimplementation, headers, retries, and response handling as before. Previously crashing inputs now returnsuccess=Falseto the model instead of aborting the agent run.Test plan
uv run ruff format src/stirrup/tools/web.py tests/test_web_search.pyuv run pytest tests/test_web_search.pyuv run ruff check src/stirrup/tools/web.py tests/test_web_search.pyMade with Cursor