[1/9] Harden code-execution command allowlists#62
Open
hi-michael-li wants to merge 3 commits into
Open
Conversation
hi-michael-li
force-pushed
the
michael-li/stirrup-01-command-allowlist
branch
from
183e5cd to
302c59a
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-01-command-allowlist
branch
from
302c59a to
f7ca694
Compare
- Reject subshells `( )` and command-prefixing keywords (time/coproc/!) so a permissive pattern cannot smuggle a different command - Fail closed on unterminated quotes rather than relying on Bash - Return a typed rejection reason with reason-specific advice and a debug log, replacing the always-"no pattern match" message; share the result builder across the local/docker/e2b backends - Expand docstrings and the code-execution guide (arithmetic expansion, double-quote expansions, start-anchoring, .search->.match migration) - Add tests for process substitution, `+=`, subshell/keyword prefixes, unterminated quotes, anchoring, and reason-specific advice Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Command allowlists could be bypassed through shell chaining, substitutions, redirections, assignments, and quoted executable text. A command that looked allowed could therefore execute an unapproved program.
What
Testing
Stack
Part 1 of 9. Next: #63.