Skip to content

Honor SDK retry configuration#65

Draft
hi-michael-li wants to merge 1 commit into
mainfrom
michael-li/stirrup-04-sdk-retries
Draft

Honor SDK retry configuration#65
hi-michael-li wants to merge 1 commit into
mainfrom
michael-li/stirrup-04-sdk-retries

Conversation

@hi-michael-li

@hi-michael-li hi-michael-li commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Why

A second retry layer could multiply provider attempts and make the configured SDK retry limit ineffective.

What

  • Let the OpenAI SDK own retries for OpenAI-compatible clients.
  • Pass the configured retry limit through once.
  • Preserve LiteLLM's existing retry behavior.

Testing

  • Focused SDK retry coverage: 2 passed.
  • Full suite: 165 passed.
  • Ruff, formatting, and diff checks pass. Type checking reports only the existing Slack optional-API warning.

@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-04-sdk-retries branch from bf2ca39 to c62d27c Compare July 14, 2026 06:27
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-03-web-fetch-ssrf branch 2 times, most recently from cfd813e to 86e8507 Compare July 14, 2026 13:24
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-04-sdk-retries branch 2 times, most recently from 630e7ec to 92e5088 Compare July 16, 2026 02:18
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-03-web-fetch-ssrf branch from 86e8507 to 19ba3bf Compare July 16, 2026 02:18
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-04-sdk-retries branch from 92e5088 to a4d3554 Compare July 16, 2026 10:33
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-03-web-fetch-ssrf branch 2 times, most recently from 5394ec4 to cbbe415 Compare July 17, 2026 05:08
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-04-sdk-retries branch 2 times, most recently from 75a871d to ee8fc1a Compare July 17, 2026 06:17
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-03-web-fetch-ssrf branch from 32e0f82 to e10a4ff Compare July 17, 2026 07:10
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-04-sdk-retries branch from ee8fc1a to bd998d7 Compare July 17, 2026 07:10
@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-03-web-fetch-ssrf branch from e10a4ff to 1235772 Compare July 17, 2026 07:35
@hi-michael-li
hi-michael-li changed the base branch from michael-li/stirrup-03-web-fetch-ssrf to main July 17, 2026 10:47
@hi-michael-li

Copy link
Copy Markdown
Contributor Author

Planned simplification

I’m going to rebuild this PR directly on main so it contains only the SDK retry-ownership change:

  • two OpenAI client files;
  • one focused behavioral test module;
  • no output-path or web-fetch ancestry.

The production change remains deliberately small: remove Stirrup’s outer retry layer and let the configured SDK retry policy own attempts.

@hi-michael-li
hi-michael-li force-pushed the michael-li/stirrup-04-sdk-retries branch from 58cb50d to d79a066 Compare July 17, 2026 17:01
@hi-michael-li hi-michael-li changed the title [4/9] Honor SDK retry configuration Honor SDK retry configuration Jul 17, 2026
@hi-michael-li

Copy link
Copy Markdown
Contributor Author

Simplification complete

  • Head: d79a066
  • Scope: 24 files (+2517/-483) → 3 files (+52/-48)
  • Rebuilt directly on main; removed all output-path and web-fetch ancestry.
  • The PR now contains only the two SDK clients and one behavioral retry test module.
  • Validation: 2 focused tests; 165 full-suite tests; Ruff, formatting, type and diff checks pass (apart from the existing Slack type warning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant