Honor SDK retry configuration#65
Draft
hi-michael-li wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 13, 2026
hi-michael-li
force-pushed
the
michael-li/stirrup-04-sdk-retries
branch
from
July 14, 2026 06:27
bf2ca39 to
c62d27c
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-03-web-fetch-ssrf
branch
2 times, most recently
from
July 14, 2026 13:24
cfd813e to
86e8507
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-04-sdk-retries
branch
2 times, most recently
from
July 16, 2026 02:18
630e7ec to
92e5088
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-03-web-fetch-ssrf
branch
from
July 16, 2026 02:18
86e8507 to
19ba3bf
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-04-sdk-retries
branch
from
July 16, 2026 10:33
92e5088 to
a4d3554
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-03-web-fetch-ssrf
branch
2 times, most recently
from
July 17, 2026 05:08
5394ec4 to
cbbe415
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-04-sdk-retries
branch
2 times, most recently
from
July 17, 2026 06:17
75a871d to
ee8fc1a
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-03-web-fetch-ssrf
branch
from
July 17, 2026 07:10
32e0f82 to
e10a4ff
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-04-sdk-retries
branch
from
July 17, 2026 07:10
ee8fc1a to
bd998d7
Compare
hi-michael-li
force-pushed
the
michael-li/stirrup-03-web-fetch-ssrf
branch
from
July 17, 2026 07:35
e10a4ff to
1235772
Compare
hi-michael-li
changed the base branch from
michael-li/stirrup-03-web-fetch-ssrf
to
main
July 17, 2026 10:47
Contributor
Author
Planned simplificationI’m going to rebuild this PR directly on
The production change remains deliberately small: remove Stirrup’s outer retry layer and let the configured SDK retry policy own attempts. |
hi-michael-li
force-pushed
the
michael-li/stirrup-04-sdk-retries
branch
from
July 17, 2026 17:01
58cb50d to
d79a066
Compare
Contributor
Author
Simplification complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A second retry layer could multiply provider attempts and make the configured SDK retry limit ineffective.
What
Testing