Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Complete abort deprecation 🎉 #53

Merged
merged 25 commits into from
Aug 19, 2020
Merged

refactor: Complete abort deprecation 🎉 #53

merged 25 commits into from
Aug 19, 2020

Conversation

Ash258
Copy link
Owner

@Ash258 Ash258 commented Jul 27, 2020 •
edited
Loading

ScoopInstaller#3628, ScoopInstaller#3936, ScoopInstaller#4135, ScoopInstaller#4230, ScoopInstaller#4529

#46, #21, #10

There is still much code duplication, but not on the bottom level. The top level duplication could be eliminated in future. There is no reason to hold up this PR due to small code repetition.

Before: A

After: B

AA
BB

@Ash258
Copy link
Owner Author

Ash258 commented Jul 27, 2020

A

B

https://i.imgur.com/H7i0yIl.png

@Ash258
Copy link
Owner Author

Ash258 commented Jul 27, 2020

Almost ready 🎉

only one last problem with download progress hiding for some reason. Should disappear as soon as it is refactored, but it will be in near future.

Needs to be proper tested on various environments

@Ash258 Ash258 added this to the 0.55 milestone Jul 27, 2020
@Ash258 Ash258 changed the title refactor(install): Easy abort deprecation refactor(install): Complete abort deprecation 🎉 Jul 27, 2020
@Ash258 Ash258 changed the title refactor(install): Complete abort deprecation 🎉 refactor: Complete abort deprecation 🎉 Jul 27, 2020
@Ash258
Copy link
Owner Author

Ash258 commented Jul 30, 2020

Test and most likely fix dependencies installation failures.

Ash258 added a commit that referenced this pull request Jul 30, 2020
@Ash258
refactor: Straightforward abort deprecation
c8f5b3b 
#46, #53

I did not expect that full deprecation will be that easy, so the original PR grow a bit and got really messy.
This is fraction of the previous PR with the easiest changes.

- Helper function
- Strict and safe `abort` replacement without additional side checks
@Ash258 Ash258 mentioned this pull request Jul 30, 2020
Merged
Ash258 added a commit that referenced this pull request Jul 30, 2020
@Ash258
refactor(decompress): Abort => Set-TerminatingError
dee46c7 
#46, #53
@Ash258 Ash258 mentioned this pull request Jul 30, 2020
Merged
@Ash258
Copy link
Owner Author

Ash258 commented Jul 30, 2020 •
edited
Loading

Last 2 things 🎉🎉🎉

  • Downloading
  • Handle specific bucket for issue prompt

@Ash258
Copy link
Owner Author

Ash258 commented Aug 8, 2020

Propertly test checkver!

@Ash258
Copy link
Owner Author

Ash258 commented Aug 8, 2020

Abort free 🎉🎉

Lets test it this weekend and it can arrive in NEW

@Ash258
Copy link
Owner Author

Ash258 commented Aug 8, 2020

Looks pretty good

Ash258
Ash258 commented Aug 8, 2020
View reviewed changes
Ash258
Ash258 commented Aug 8, 2020
View reviewed changes
@Ash258
Copy link
Owner Author

Ash258 commented Aug 13, 2020 •
edited
Loading

Fix local installation #58

Ash258
Ash258 commented Aug 16, 2020
View reviewed changes
@Ash258 Ash258 marked this pull request as ready for review August 19, 2020 19:23
@Ash258
Copy link
Owner Author

Ash258 commented Aug 19, 2020

Lets do it

@Ash258 Ash258 merged commit 1a3beda into NEW Aug 19, 2020
@Ash258 Ash258 deleted the abortWave3InstallEasy branch August 19, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55
Development

Successfully merging this pull request may close these issues.
1 participant
@Ash258