fix: separate dashboard and browser bookmarks; fix light theme contrast#143
Open
rudra-chothe wants to merge 1 commit into
Open
fix: separate dashboard and browser bookmarks; fix light theme contrast#143rudra-chothe wants to merge 1 commit into
rudra-chothe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes Issue #122
This PR fixes two issues:
1. Bookmarks data source separation
The
BookmarksSectioncomponent was only reading fromuseBrowserBookmarks()(Chrome extension API), completely ignoring thebookmarks: BookmarkItem[]list managed byDashboardStateProvider. This meant app-saved bookmarks (persisted inlocalStorage) were never shown in the UI.Changes:
BookmarksSectionnow renders two distinct sections:useDashboardState(), always visible, with inline add and delete supportSavedBookmarkItemcomponent handles rendering of individual saved bookmarks with favicon, link, and delete button2. Light theme contrast and card styling
All dashboard cards (
glass-card) remained dark gray in light mode, and most interactive elements used hardcodedwhite/*opacity classes making them invisible on a light background.Changes:
.glass-cardnow uses a light/translucent background in light mode and dark/translucent in dark modetext-white) →text-foreground; author (text-white/50) →text-muted-foregroundbg-white/5,border-white/5,hover:bg-white/5,hover:bg-white/10→foreground/*equivalents acrossDashboardHeader,TasksSection,TechNewsSection,BookmarksSection,TaskItem,SavedBookmarkItemvar(--foreground)Type of Change
Screenshots / Screen Recording
Toggle between light and dark mode on the dashboard to observe:
How to Test
npm run devand openhttp://localhost:5173+→ enter a URL → press Save or Enter → item appearslocalStorageChecklist
npm run lintpasses.npm run typecheckpasses.npm run buildsucceeds.