Conversation
Conflicts: scimes/orion2scimes.py scimes/scimes.py
Contributor
|
👍 to me |
Contributor
|
Thanks for this Adam! About the bug, I am using the 0.1.0 version of astrodendro and I am not getting the error... |
Contributor
Author
|
I think you don't have the latest dev version of astrodendro - there was a bug introduced, so I submitted this fix: dendrograms/astrodendro#133 |
Merge latest upstream
Conflicts: scimes/scimes.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dcolombo I've fixed a few issues with imports here. I think you were doing
%run -i orion2scimes.pyafter having runfrom pylab import *; that's not generally true so I've fixed that stuff up.I'm still running into one issue:
which could be a genuine bug in astrodendro or it could be that we're passing the wrong things to the plotter