fix: Fixed too strict zod-schema for global messages #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
strandlie
requested review from
mortennordseth,
mathiazom,
jonasbrunvoll,
rosvik and
reidzeibel
mathiazom
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if the old implementation is on purpose, but it seems a little odd so here is a suggestion.
The old implementation would not accept a globalMessage unless all of the values in
contextexisted inGlobalMessageContextEnum. Examples of where this is not true areapp-assistantandapp-ticketing.Added a little flexibility where values in
GlobalMessageContextEnumare checked and cast as such, but other values are discarded. Also added some documentation on this.