Skip to content

fix: spawn sidebar via sh -c for non-POSIX login shells #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hapticdata wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: spawn sidebar via sh -c for non-POSIX login shells #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/runtime-rs/src/tmux_provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,10 +820,16 @@ impl MuxProvider for TmuxProvider {
// pane works even when the parent pane's cwd is unrelated to the
// workspace (e.g. tmux sessions whose default cwd is `$HOME`). Falls
// back to the literal path if the env is unset.
let command = format!(
//
// tmux runs this command through the user's `default-shell` (`$SHELL`),
// which may be a non-POSIX shell (e.g. fish) that can't parse
// `${VAR:-default}`. Wrap it in `sh -c` so the POSIX syntax is always
// interpreted by a POSIX shell.
let inner = format!(
"OPENSESSIONS_SESSION_NAME={} OPENSESSIONS_WINDOW_ID={window_id} REFOCUS_WINDOW={window_id} exec \"${{OPENSESSIONS_DIR:-.}}\"/{scripts_dir}/start.sh",
target.session_name,
);
let command = format!("sh -c {}", shell_quote(&inner));
let new_pane = self.client.split_sidebar_pane(
&target.id,
position == SidebarPosition::Left,
Expand Down