Filter deactivated comments #401
Merged
+147
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schottra
approved these changes
Sep 19, 2025
| @@ -36,6 +36,13 @@ func (app *ApiServer) v1TrackCommentCount(c *fiber.Ctx) error { | |||
| WHERE score < 0 | |||
| ), | |||
|
|
|||
| -- Deactivated users | |||
| deactivated_users AS ( | |||
There was a problem hiding this comment.
Wouldn't this potentially be a huge set that we mostly don't use? Wondering if this is better as just a join on users and then filter afterwards on users.is_deactivated. Maybe I don't understand how the query planning works. Does it evaluate this whole result set and store it before moving on? Or would it pull from this query as needed for processing the final result set?
There was a problem hiding this comment.
inlined by default!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.