Update sdk with new v1 endpoints and types#13721
Conversation
|
| input.stream_conditions != null && | ||
| isContentUSDCPurchaseGated(input.stream_conditions) | ||
| ? usdcPurchaseConditionsToSDK(input.stream_conditions) | ||
| ? (usdcPurchaseConditionsToSDK( |
There was a problem hiding this comment.
i think merge with typeerror instead, we can fix in my follow up branch
dylanjeffers
changed the title
| return { | ||
|
|
||
| 'data': value.data === undefined ? undefined : ((value.data as Array<any>).map(PlaylistToJSON)), | ||
| 'latest_chain_block': value.latestChainBlock, |
There was a problem hiding this comment.
did we add these fields in api land? idk if we should tbh
There was a problem hiding this comment.
i see, yeah can take a look
|
|
||
| /** | ||
| * | ||
| * Type of entity that can be commented on |
| * @type {string} | ||
| * @memberof Playlist | ||
| */ | ||
| releaseDate?: Date; |
There was a problem hiding this comment.
On api land, this should be format: Date i think
| * @memberof PlaylistAddedTimestamp | ||
| */ | ||
| trackId: string; | ||
| metadataTimestamp: number; |
There was a problem hiding this comment.
I think this should be excluded/optional
| /** | ||
| * Metadata timestamp | ||
| * @type {number} | ||
| * |
| title?: string; | ||
| /** | ||
| * Full URL link to the content | ||
| * URL link to the content |
There was a problem hiding this comment.
lol, probably fine that this said "Full" 🤷
| /** | ||
| * | ||
| * @type {RemixParent} | ||
| * @memberof Track | ||
| */ | ||
| remixOf?: RemixParent; | ||
| remixOf: RemixParent; |
There was a problem hiding this comment.
interesting, this isn't optional?
| /** | ||
| * | ||
| * @type {string} | ||
| * @memberof Track | ||
| */ | ||
| creditsSplits?: string; | ||
| routeId: string; |
There was a problem hiding this comment.
adding note for future work to remove some of these unused things
| * @memberof Track | ||
| */ | ||
| download?: MediaLink; | ||
| trackSegments: Array<TrackSegment>; |
There was a problem hiding this comment.
this too is removable in teh future
| * @memberof Track | ||
| */ | ||
| license?: string; | ||
| resourceContributors?: Array<object>; |
There was a problem hiding this comment.
do we have types for these maybe?
| * @memberof Track | ||
| */ | ||
| musicalKey?: string; | ||
| indirectResourceContributors?: Array<object>; |
| * @memberof Track | ||
| */ | ||
| parentalWarningType?: string | null; | ||
| rightsController?: object; |
There was a problem hiding this comment.
and htis and the following two props
| /** | ||
| * | ||
| * @type {string} | ||
| * @memberof Track | ||
| */ | ||
| isrc?: string; | ||
| releaseDate?: string; |
There was a problem hiding this comment.
this should be format: Date i think too?
2 participants
Adds updated v1 endpoints to sdk, and updates various type issues