Skip to content

fix(forge-vesting-factory): add TTL extension calls for all persisten… #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Austinaminu2 merged 2 commits into from
Apr 28, 2026
Merged

fix(forge-vesting-factory): add TTL extension calls for all persisten… #525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b906924
fix(forge-vesting-factory): add TTL extension calls for all persisten…
Apr 27, 2026
f6728b8
Merge branch 'main' into fix/499-ttl-extension-vesting-factory
Austinaminu2 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions contracts/forge-vesting-factory/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,19 @@ assert_eq!(factory.get_schedule_count(), 2);

---

## Storage TTL Strategy

All persistent storage entries in this contract are subject to Stellar's TTL expiry (~30 days without a bump). To prevent vesting data from expiring and locking beneficiary tokens, every mutating function extends the TTL of the entries it touches:

| Function | Entries bumped |
| :--- | :--- |
| `create_schedule()` | `Schedule(id)`, `ScheduleCount` |
| `claim()` | `Schedule(id)`, `Claimed(id)` |
| `cancel()` | `Schedule(id)`, `Claimed(id)`, `VestedAtCancel(id)` |

All bumps use a minimum threshold of **17 280 ledgers** (~1 day) and a target of **34 560 ledgers** (~2 days), matching the convention used by `forge-governor`, `forge-multisig`, and `forge-stream`.

If a schedule is inactive for an extended period, an off-chain keeper or the beneficiary themselves should call `get_status()` (which does not bump TTL) and then `claim()` to refresh the TTL before expiry.
## Storage Strategy

`ScheduleCount` is stored in **persistent** storage (not instance storage). This is critical: if `ScheduleCount` were in instance storage and that entry expired, the counter would reset to 0 and new schedules would silently overwrite existing ones in persistent storage, permanently destroying beneficiary vesting data.
Expand Down
Loading