Skip to content

Commit

Permalink
Improve common review items list. #2.
Browse files Browse the repository at this point in the history
  • Loading branch information
wparad committed Jul 23, 2023
1 parent f13096b commit 6869fbf
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,16 @@ podman stop $CID && podman rm $CID
```

### Common review items
* Add authentication to the configuration class.
* Change configuration class name to be consistent
* [ ] Add authentication to the configuration class.
* [ ] Change configuration class name to be consistent
* Specify all the inputs to be consistent across languages
* Update documentation
* [ ] Update documentation
* Make sure markdown is valid
* Remove unnecessary links
* Add first class examples to readme.md + api documentation
* Url encode all url inputs, frequently the generator doesn't do that
* Remove any unnecessary validations from object and parameter injection, often there are some even when properties are allowed to be null
* The service client code to generate a JWT from private key needs to be added
* Top level tags from the API should accessible from the base class: `authressClient.accessRecords.getRecords(...)`
* Test
* [ ] Url encode all url inputs, frequently the generator doesn't do that
* [ ] Remove any unnecessary validations from object and parameter injection, often there are some even when properties are allowed to be null
* [ ] The service client code to generate a JWT from private key needs to be added
* [ ] Add UnauthorizedError type to the authorizeUser function
* [ ] Top level tags from the API should accessible from the base class: `authressClient.accessRecords.getRecords(...)`
* [ ] Test

0 comments on commit 6869fbf

Please sign in to comment.