fix: agent output modal ui/ux and task list with spec/full plan mode #493
Conversation
…ndling in agent info panel - Reduced the maximum height of the task progress panel from 300px to 200px for better UI consistency. - Introduced a new `effectiveTodos` calculation in the agent info panel to correctly display tasks from `planSpec` when available, ensuring accurate task counts and statuses. - Updated references to use `effectiveTodos` instead of the original `agentInfo.todos` for task display logic in the agent info panel. - Adjusted the height of various modal components to align with the new task progress panel height.
Summary of ChangesHello @Shironex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the user interface and experience for agent output and task management. It introduces a more robust way to display agent tasks by prioritizing structured plan specifications, while also making several layout adjustments to the agent output modal for improved visual presentation. These changes aim to provide clearer and more consistent feedback on agent progress and activities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Shironex
added
Bug
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a fix for the task list display on Kanban cards, ensuring tasks are correctly sourced from planSpec when available. The implementation using useMemo to create effectiveTodos is well-done and correctly handles the fallback to agentInfo.todos. Additionally, several UI/UX tweaks have been made to reduce the height of modal components, which should improve the layout on smaller screens. I have one minor suggestion to improve code conciseness.
| // instead of emitting TodoWrite tool calls in the output log | ||
| const effectiveTodos = useMemo(() => { | ||
| // First priority: use planSpec.tasks if available (modern approach) | ||
| if (feature.planSpec?.tasks && feature.planSpec.tasks.length > 0) { |
There was a problem hiding this comment.
The condition to check for the existence and non-emptiness of feature.planSpec.tasks can be made more concise by using optional chaining on the length property. The current check is a bit verbose.
| if (feature.planSpec?.tasks && feature.planSpec.tasks.length > 0) { | |
| if (feature.planSpec?.tasks?.length) { |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… fresh planSpec integration - Added support for real-time task status updates using WebSocket events, allowing the Kanban card to reflect current task progress accurately. - Introduced a new state for fresh planSpec data fetched from the API to ensure the agent info panel displays up-to-date task information. - Updated the effectiveTodos calculation to prioritize fresh planSpec data and incorporate real-time status, improving task display accuracy. - Enhanced the logic to listen for relevant WebSocket events and update task statuses accordingly, ensuring synchronization with the agent output modal.
Changes from branch feature/v0.11.0rc-1768413909856-a0al