Improve file pattern arguments handling & tests

bin/pr_changed_files

@@ -68,6 +68,11 @@ while [[ "$#" -gt 0 ]]; do
             fi
             mode="${1#--}"
             shift
+            # Check if there are any patterns after the flag
+            if [[ "$#" -eq 0 || "$1" == "--"* ]]; then
+                echo "Error: must specify at least one file pattern" >&2
+                exit 1
+            fi
             while [[ "$#" -gt 0 && "$1" != "--"* ]]; do
                 patterns+=("$1")
                 shift
@@ -104,21 +109,6 @@ if [[ -z "$mode" ]]; then
     exit 0
 fi
 
-if [[ ${#patterns[@]} -eq 0 ]]; then
-    echo "Error: must specify at least one file pattern" >&2
-    exit 1
-fi
-
-# No files changed
-if [[ ${#changed_files[@]} -eq 0 ]]; then
-    if [[ "$mode" == "all-match" ]]; then
-        echo "true"
-    else
-        echo "false"
-    fi
-    exit 0
-fi
-
 # Returns 0 if the file matches any of the patterns, 1 otherwise
 file_matches_any_pattern() {
     local file="$1"

tests/pr_changed_files/test_edge_cases.sh

@@ -32,11 +32,13 @@ if pr_changed_files --any-match 2>/dev/null; then
     exit 1
 fi
 
+# [Test] Flag followed by another flag
+output=$(pr_changed_files --any-match --something 2>&1 || true)
+assert_output "Error: must specify at least one file pattern" "$output" "Should fail with correct error when flag is followed by another flag"
+
 # [Test] Mutually exclusive options
-if pr_changed_files --any-match "*.txt" --all-match "*.md" 2>/dev/null; then
-    echo "Should fail when using both --any-match and --all-match"
-    exit 1
-fi
+output=$(pr_changed_files --any-match "*.txt" --all-match "*.md" 2>&1 || true)
+assert_output "Error: either specify --all-match or --any-match; cannot specify both" "$output" "Should fail with correct error when using mutually exclusive options"
 
 # [Test] Files with spaces and special characters
 mkdir -p "folder with spaces/nested\!\@\#\$folder"