Enhance pr_changed_files with exit codes and string output #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
AliSoftware
reviewed
Feb 13, 2025
AliSoftware
reviewed
Feb 13, 2025
AliSoftware
reviewed
Feb 18, 2025
Comment on lines
66
to
69
| # $1 - Expected return code | ||
| # $2 - Actual return code | ||
| # $3 - Actual output | ||
| # $4 - Expected output |
There was a problem hiding this comment.
Order of arguments feels a bit strange, with Expected and Actual being intertwined like that.
I'd suggest [Expected return code, Actual return code, Expected output, Actual output] instead?
There was a problem hiding this comment.
Indeed -- updated on feb51f0
Documentation updates Co-authored-by: Olivier Halligon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the discussion started on woocommerce/woocommerce-ios#15086 (comment).
This PR adds both exit codes (default mode) and
"true""false"output (using--stdoutflag) to thepr_changed_filescommand, updating documentation and tests accordingly.CHANGELOG.mdif necessary.