feat: tests for sentences containing a decade #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure if this is the best way/pace to do such tests. see discord messages: https://discord.com/channels/1335035237213671495/1335035237213671498/1342765690813157388
…cade-lex-sentence-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
I only mentioned it in Discord when nobody else was active.
On builds straight from master I was seeing the 's' after decades like '1990s' flagged, even though my decade lexer has been merged.
Description
I checked the tests and we only had unit tests looking for edge cases. This adds a positive and a negative test against the sentence mentioned. Let me know if there's a better way to code them or if they belong in some other file. The other lexers in
harper-core/src/lexing/mod.rsalso didn't have any in-context tests.How Has This Been Tested?
cargo testpasses all tests butjust testgives strange new errors I've never seen before, including creating supposed screenshot png's but those are all blank. I think this is something unrelated that's been pushed to master in the same timeframe my decade lexer was pushed??Checklist