Forms: Remove Salesforce integration from third party files

[coder-karen]

Fixes https://github.com/Automattic/jpop-issues/issues/9331

Proposed changes:

• This PR removes the third party Salesforce integration, to prevent duplicate Salesforce form submissions.
• It looks like the Salesforce integration was made within the forms package here - Forms: add post to url hook #30191 in order to replace the third party integration added here - Jetpack: Add Salesforce Lead form template #26903.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jpop-issues/issues/9331

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Replicating the issue:

• Add a form block to a test site, and choose the Salesforce Lead Form variation.
• In the block settings sidebar, add an organization ID. You don't need a Salesforce account for this, but you can get a free 30 day trial at salesforce.com if preferred. Otherwise, adding a dummy organization ID will work, such as TESTINGONETWOTHREE-1234.
• Add breakpoints, or just error_log calls, at the points mentioned in the issue linked above. Alternatively, add a snippet (eg. using a Code Snippets plugin) to hook into pre_http_request, to listen to requests made with wp_remote_post:

add_filter('pre_http_request', function ($pre, $parsed_args, $url) {
    if ($parsed_args['method'] === 'POST') {
        error_log('wp_remote_post called to URL: ' . $url);
        error_log('Request Args: ' . print_r($parsed_args, true));
    }
    return $pre;
}, 10, 3);

• You may need to comment out the if ( $is_spam ) { checks in both methods if Akismet is enabled.
• On the front-end, add a submission
• Notice in your error logs that there will be two submissions to the Salesforce URL - webto.salesforce.com.... (or two entries in the corresponding files if adding debugging).

To test the fix:

• Apply this PR, and add the same debugging as in the earlier step.
• Add a submission (making sure the details are different), and notice that there should only be one submission to the
  webto.salesforce.com.... URL.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/salesforce-forms-duplicate-data branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/salesforce-forms-duplicate-data
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[CGastrell]

Code looks good, the removal is simple enough. I wasn't aware there was a new integration for Salesforce 👍