Premium Content: add email rendering #46006

arcangelini · 2025-11-20T00:08:01Z

Closes https://linear.app/a8c/issue/CML-1027/fix-premium-contentcontainer-email-render

Proposed changes:

Add email_render_callback for jetpack/recurring-payments jetpack/payment-buttons and premium-content/container

Old Renderer	Before	After

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

NA

Does this pull request change what data or activity we track or use?

No

Testing instructions:

This change needs to be pulled into WPCOM to test since emails and previews are generated from WPCOM. To test on different sites make sure your site is using your sandbox for the public-api.wordpress.com.

Setup Newsletter plans for the site
Add wc-email-editor sticker to your blog
Add Recurring Payment buttons and Premium Content blocks to the post and Publish
View the email using the Email Preview from the post editor
Send a test email to verify the same results.

github-actions · 2025-11-20T00:08:59Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/premium-content-block-email-render branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/premium-content-block-email-render

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-11-20T00:09:13Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: December 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-11-20T00:18:50Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/extensions/blocks/payment-buttons/payment-buttons.php	6/40 (15.00%)	15.00%	3 ❤️‍🩹
projects/plugins/jetpack/modules/memberships/class-jetpack-memberships.php	89/438 (20.32%)	1.82%	1 ❤️‍🩹
projects/plugins/jetpack/extensions/blocks/premium-content/login-button/login-button.php	1/34 (2.94%)	2.94%	0 💚

Full summary · PHP report · JS report

jeherve

I'm most likely missing something in my set up, because I do not see the payment buttons in the emails at all, whether I test on a Jetpack site or a wpcom simple site.

I also noticed some oddities with colors and text alignment:

Editor

(centered italic text, buttons with custom colors from the theme palette, text with custom color, other text with color from the theme palette)

Email preview

Email

jeherve · 2025-11-26T15:28:36Z

projects/plugins/jetpack/modules/memberships/class-jetpack-memberships.php

+		}
+
+		// Reuse the button block's email rendering method.
+		return \Automattic\Jetpack\Extensions\Button\render_email( $block_content, $button_block, $rendering_context );


I think I would check if the class exists just to be sure, since Jetpack allows disabling the registration of some blocks via filters. Some users may have disabled the button block for some reason (although I would assume it would cause them trouble with the paid content buttons already).

jeherve · 2025-11-26T15:49:19Z

projects/plugins/jetpack/tests/php/extensions/blocks/class-mock-flex-layout-renderer.php

I'm thinking we may want to place those in a new subdirectory, to avoid mixing them with regular block tests. It would be easier to locate them in the future, if we need mocks again.

arcangelini added 2 commits November 20, 2025 01:04

Premium Content: add email rendering

ce90700

changelog

3b318da

arcangelini requested a review from a team November 20, 2025 00:08

arcangelini self-assigned this Nov 20, 2025

github-actions bot added [Block] Paid Content aka Premium Content [Block] Payment Buttons [Feature] Memberships [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Nov 20, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 20, 2025

arcangelini added 6 commits November 20, 2025 12:32

Fix type error

6bd6d19

Fix class exist phan error

cb67a0e

Skip phan error

93462ea

Check method

79ef162

Fix missing method error

cebfcd2

Add basic tests

e266e64

github-actions bot added the [Tests] Includes Tests label Nov 21, 2025

arcangelini and others added 10 commits November 21, 2025 17:33

Fix tests

268be14

Allow for empty array

85da49f

Remove unused suppression?

9969b5d

Merge branch 'trunk' into add/premium-content-block-email-render

4e5a3c7

Add button check

ffc4150

Fix recurring payment tests

ab09e7a

Fix last tests

9d7c1ea

Add extra test

6c12232

Fix tests and address feedback

dc4e2b4

Merge branch 'trunk' into add/premium-content-block-email-render

c4b5406

arcangelini added the Enhancement label Nov 24, 2025

arcangelini marked this pull request as ready for review November 24, 2025 12:31

Merge branch 'trunk' into add/premium-content-block-email-render

db7bf27

jeherve reviewed Nov 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Premium Content: add email rendering #46006

Premium Content: add email rendering #46006

arcangelini commented Nov 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

jeherve left a comment

Uh oh!

jeherve Nov 26, 2025

Uh oh!

jeherve Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Premium Content: add email rendering #46006

Are you sure you want to change the base?

Premium Content: add email rendering #46006

Conversation

arcangelini commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

jeherve left a comment

Choose a reason for hiding this comment

Uh oh!

jeherve Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

jeherve Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arcangelini commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading

jp-launch-control bot commented Nov 20, 2025 •

edited

Loading