-
Notifications
You must be signed in to change notification settings - Fork 843
Forms: use better default strategy for input styling #46038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y, bg color can be defaulted using var()
… 'field' and 'fieldText'
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
Fixes FORMS-299
Proposed changes:
This PR attempts to stabilize the fallback strategy for input background. The problem is one of balance between defaults, theme overrides and form elements trying to blend with the themes.
We're now trying to selectively declare the variable so it can be defaulted and we're using the default browsers use to style the inputs:
fieldandfieldTextto refer to CSSbackground-colorandcolorproperties.Themes might always incur in overrides or lack of styling out of our control, we do our best to probe the styles and
Some themes were selected for showing symptoms of the issue, others because of popularity. Tested with:
Other information:
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Add a form with as many fields as possible. Verify they look the same on editor and frontend.
Change both form and input backgrounds and verify again.
Some themes might lack styling or have purposely transparent backgrounds on inputs. This leads to unexpected results and will be defaulted to
fieldcolor which, depending on dark/light theme, might become white/black.See that input text is readable (good contrast), unless theme or custom colors make it otherwise.