-
Notifications
You must be signed in to change notification settings - Fork 843
Forms: fix outlined leading radius #46048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a visual inconsistency in the outlined form style where the leading notch element was missing border style and border radius properties in the editor view. The fix ensures the editor appearance matches the frontend rendering and maintains consistency with the other notch elements (notch, filler, and trailing).
- Adds
border-styleandborder-radiusCSS properties to.notched-label__leadingin editor styles - Aligns editor styles with existing frontend styles in grunion.scss
- Ensures consistent border rendering across all notch elements in outlined form styles
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/packages/forms/src/blocks/contact-form/editor.scss | Adds missing border-style and border-radius properties to the leading notch element to match frontend styles and other notch elements |
| projects/packages/forms/changelog/fix-forms-outlined-leading-radius | Documents the patch fix for the outlined style leading notch border settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edanzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! LGTM.
Fixes FORMS-424
Proposed changes:
This PR adds initial border style settings for the leading notch used on Outlined styles.
Before:

After:

Other information:
Jetpack product discussion
p1763644719158009-slack-C086RGTJT1D
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Use a theme showing the symptoms, like Assembler. Insert a form, see that inputs have their border radius as set by theme.
Switch the form style to Outlined. See that border radius on the inputs, until changed, remain the same as before switching the style.
Confirm the frontend reflects the style.
Try one or two more themes to confirm no regressions.