Skip to content

Jetpack newsletter settings skeleton #46049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: trunk
Choose a base branch
from
Open

Jetpack newsletter settings skeleton #46049

wants to merge 24 commits into from
+781 −1

Conversation

@dsas
Copy link
Contributor

@dsas dsas commented Nov 21, 2025 •
edited
Loading

Fixes Dotcom-15285

Proposed changes:

Add a skeleton package that can host newsletters related functionality, though in the immediate future only the Settings page will be added.

Todo: Create a mirror repo once agreed

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

It's just a skeleton and a PoC

  1. Apply the jetpack plugin to your site
  2. Make add_filter( 'jetpack_wp_admin_newsletter_settings_enabled', '__return_true' ); run early, e.g. by adding it to a new mu-plugin
  3. Go to /wp-admin/admin.php?page=jetpack-newsletter (or /wp-admin/admin.php?page=jetpack_modules → Newsletter → Configure)
  • You should see "This is a proof of concept, I am rendered via React"

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the dotcom-14314-untangling-jetpack-newsletter branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack dotcom-14314-untangling-jetpack-newsletter

bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotcom-14314-untangling-jetpack-newsletter

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Tests] Includes Tests Docs [Package] Newsletter Settings labels Nov 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: December 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 21, 2025
@dsas dsas changed the title Dotcom 14314 untangling jetpack newsletter Jetpack newsletter settings skeleton Nov 21, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Nov 21, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/modules/subscriptions.php 49/407 (12.04%) 0.43% 0 💚

1 file is newly checked for coverage.

File Coverage
projects/packages/newsletter/src/class-settings.php 0/45 (0.00%) 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@dsas dsas force-pushed the dotcom-14314-untangling-jetpack-newsletter branch from 98bc3b5 to 33a9b35 Compare November 24, 2025 22:40
@dsas dsas added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Nov 27, 2025
@dsas dsas self-assigned this Nov 27, 2025
@dsas dsas marked this pull request as ready for review November 27, 2025 14:08
jeherve
jeherve reviewed Nov 27, 2025
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be good to create the mirror repo, but I left a few comments below for some minor changes.

projects/packages/newsletter/src/class-settings.php
* @return bool
*/
private function expose_to_users() {
return apply_filters( 'jetpack_wp_admin_newsletter_settings_enabled', false );
Copy link
Member

@jeherve jeherve Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to add a docblock here so the filters can be documented in the codex thanks to the parser.

Copy link
Contributor Author

@dsas dsas Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend this just as a temporary feature flag so users don't see it until it's ready and I can work in small PRs. Is documenting it in the codex the right thing to do?

@jeherve jeherve added [Type] Feature Development of a new feature and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve left review comments

Assignees

@dsas dsas

Labels

Docs I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Package] Newsletter Settings [Package] Newsletter [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Tests] Includes Tests [Type] Feature Development of a new feature [Type] Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsas @jeherve