eslint-changed: Fix running from a git subdir #46064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with `--git` from a subdirectory of the repo, we need to make a few adjustments to get things working correctly: * Pass `.` to `git diff` if no command line files are passed, as it's almost certain the user only wants files in the current subdirectory linted. * When command line files are passed, the `files` array needs to have them relative to `diffBase` rather than `process.cwd()`. * Pass absolute file names to `eslint`, as otherwise it interprets them relative to `process.cwd()` when they're actually relative to `diffBase`. Fixes #46060
anomiex
added
[Type] Bug
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
tbradsha
approved these changes
Nov 24, 2025
Contributor
tbradsha
left a comment
tbradsha
left a comment
There was a problem hiding this comment.
Took a bit to reproduce, but seems fine.
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MONOREP-255
Proposed changes:
When running with
--gitfrom a subdirectory of the repo, we need to make a few adjustments to get things working correctly:.togit diffif no command line files are passed, as it's almost certain the user only wants files in the current subdirectory linted.filesarray needs to have them relative todiffBaserather thanprocess.cwd().eslint, as otherwise it interprets them relative toprocess.cwd()when they're actually relative todiffBase.Other information:
Jetpack product discussion
Fixes #46060
Does this pull request change what data or activity we track or use?
No
Testing instructions: