Forms: Prefix notification IDs to prevent conflicts

[lezama]

Proposed changes:

• Prefix all notification IDs in the Forms package with jp-forms- to prevent conflicts with other plugins that may use generic notification IDs like 'empty-spam', 'empty-trash', etc.
• Updated notification IDs in the following components:
  • Empty Spam Button: empty-spam → jp-forms-empty-spam
  • Empty Trash Button: empty-trash → jp-forms-empty-trash
  • Mark as Spam Action: mark-as-spam-action → jp-forms-mark-as-spam-action
  • Mark as Not Spam Action: mark-as-not-spam-action → jp-forms-mark-as-not-spam-action
  • Restore Action: restore-action → jp-forms-restore-action
  • Move to Trash Action: move-to-trash-action → jp-forms-move-to-trash-action
  • Delete Action: move-to-trash-action → jp-forms-delete-action (also fixed incorrect ID)
  • Mark as Read Action: mark-as-read-action → jp-forms-mark-as-read-action
  • Mark as Unread Action: mark-as-unread-action → jp-forms-mark-as-unread-action

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Enable Jetpack Forms on a WordPress site
• Go to the Forms dashboard (Jetpack > Forms)
• Test the following actions and verify that success notifications appear correctly:
  1. Mark a response as spam - verify "Marked as spam" notification appears
  2. Mark a response as not spam - verify notification appears
  3. Move a response to trash - verify "Moved to trash" notification appears
  4. Restore a response from trash - verify "Restored from trash" notification appears
  5. Empty spam folder (if there are spam items) - verify "Emptied spam" notification appears
  6. Empty trash folder (if there are trash items) - verify "Emptied trash" notification appears
  7. Mark responses as read/unread - verify notifications appear
  8. Delete responses permanently - verify "Deleted" notification appears
• Verify that the notifications work correctly and don't conflict with any other plugin notifications
• Ensure undo actions still work correctly for applicable notifications

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/forms-notification-ids-prefix branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/forms-notification-ids-prefix

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

[simison]

I didn't test-run but the code looks good.

This didn't fix the bug we were seeing but it's a good practise to prefix IDs Nonetheless.

[simison]

BTW I noticed createErrorNotice is missing ID. Not sure if it has consequences.

[simison]

No prefix here

[simison]

No prefix

[simison]

No ID at all 😅