Skip to content

Conversation

@alshakero
Copy link
Member

@alshakero alshakero commented Nov 24, 2025

Fixes DOTCOM-15298

Proposed changes:

ExPlat endpoint was only registered when the site had admin-style set to Default (vs wp-admin). This is unexpected and it should be registered in all sites.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Apply this to an atomic site using the Jetpack Beta Plugins (WordPress.com Features module).
  2. Visit /wp-json/jetpack/v4/explat/assignments?experiment_name=wpcom_help_center_ai_workflow_and_prompt_changes&platform=wpcom&as_connected_user=true&_locale=user
  3. You shouldn't get 404.

@github-actions github-actions bot added [Feature] WPCOM API [Package] Explat [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Nov 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: December 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the dotcom-15298-explat-fix-experiment-endpoint-in-atomic-sites branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotcom-15298-explat-fix-experiment-endpoint-in-atomic-sites

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@alshakero alshakero marked this pull request as ready for review November 24, 2025 18:04
@alshakero alshakero added the [Type] Bug When a feature is broken and / or not performing as intended label Nov 24, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Nov 24, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php 0/328 (0.00%) 0.00% 1 ❤️‍🩹

Full summary · PHP report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@alshakero alshakero added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Nov 24, 2025
Copy link
Member

@ehg ehg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changelog concerns, but looks good. Tests well.

ehg
ehg previously approved these changes Nov 25, 2025
require_once __DIR__ . '/features/help-center/class-help-center.php';
}
require_once __DIR__ . '/features/html-block-restricted-tags/html-block-restricted-tags.php';
require_once __DIR__ . '/features/explat-proxy-endpoint/explat-proxy-endpoint.php';
Copy link
Member

@mmtr mmtr Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to block self-hosted Jetpack sites from using ExPlat, since jetpack-mu-wpcom is not available on those sites. Is this intentional?

We had several experiments in the past specifically for self-hosted Jetpack sites (example: pbxNRc-4hD-p2)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man. I considered it but didn't worry about it based on an incorrect assumption. The point of the proxy is to proxy requests on behalf of WordPress.com users; otherwise, users can call public-api directly (it even allows CORS). But apparently, this client proxies anonymous requests as well. I'll have to find a different place :(

@alshakero alshakero force-pushed the dotcom-15298-explat-fix-experiment-endpoint-in-atomic-sites branch from f28b074 to d254c3d Compare November 25, 2025 12:46
@alshakero alshakero changed the title Move ExPlat proxy to a more general place Register ExPlat client in Jetpack Mu Wpcom Nov 25, 2025
@github-actions github-actions bot added the [Plugin] mu wpcom jetpack-mu-wpcom plugin label Nov 25, 2025
@alshakero alshakero merged commit 8b781a7 into trunk Nov 25, 2025
66 checks passed
@alshakero alshakero deleted the dotcom-15298-explat-fix-experiment-endpoint-in-atomic-sites branch November 25, 2025 13:39
@github-actions github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs [Feature] WPCOM API I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [mu wpcom Feature] Explat Proxy Endpoint [mu wpcom Feature] Help Center [Package] Explat [Package] Jetpack mu wpcom WordPress.com Features [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants