-
Notifications
You must be signed in to change notification settings - Fork 843
Register ExPlat client in Jetpack Mu Wpcom #46066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register ExPlat client in Jetpack Mu Wpcom #46066
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 1 file.
Coverage check overridden by
I don't care about code coverage for this PR
|
ehg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changelog concerns, but looks good. Tests well.
...kages/jetpack-mu-wpcom/changelog/dotcom-15298-explat-fix-experiment-endpoint-in-atomic-sites
Outdated
Show resolved
Hide resolved
...kages/jetpack-mu-wpcom/changelog/dotcom-15298-explat-fix-experiment-endpoint-in-atomic-sites
Outdated
Show resolved
Hide resolved
| require_once __DIR__ . '/features/help-center/class-help-center.php'; | ||
| } | ||
| require_once __DIR__ . '/features/html-block-restricted-tags/html-block-restricted-tags.php'; | ||
| require_once __DIR__ . '/features/explat-proxy-endpoint/explat-proxy-endpoint.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to block self-hosted Jetpack sites from using ExPlat, since jetpack-mu-wpcom is not available on those sites. Is this intentional?
We had several experiments in the past specifically for self-hosted Jetpack sites (example: pbxNRc-4hD-p2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh man. I considered it but didn't worry about it based on an incorrect assumption. The point of the proxy is to proxy requests on behalf of WordPress.com users; otherwise, users can call public-api directly (it even allows CORS). But apparently, this client proxies anonymous requests as well. I'll have to find a different place :(
f28b074 to
d254c3d
Compare
Fixes DOTCOM-15298
Proposed changes:
ExPlat endpoint was only registered when the site had admin-style set to Default (vs wp-admin). This is unexpected and it should be registered in all sites.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
/wp-json/jetpack/v4/explat/assignments?experiment_name=wpcom_help_center_ai_workflow_and_prompt_changes&platform=wpcom&as_connected_user=true&_locale=user