Skip to content

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 24, 2025

Closes MONOREP-257

Proposed changes:

Since we can have comments now that this is in pnpm-workspace.yaml instead of package.json, let's add comments.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Proofread?

Since we can have comments now that this is in `pnpm-workspace.yaml`
instead of `package.json`, let's add comments.
@anomiex anomiex requested a review from a team November 24, 2025 20:39
@anomiex anomiex self-assigned this Nov 24, 2025
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay.

I'll note that for someone unfamiliar with the setting, the comments are a bit ambiguous as to whether they enable or disable the attempt to do X.

@anomiex anomiex merged commit 736a288 into trunk Nov 25, 2025
75 of 77 checks passed
@anomiex anomiex deleted the add/comments-for-ignoredBuiltDependencies branch November 25, 2025 15:19
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants