Inactive Users: REPORT mode creates permanent inactive flag

[katag9k]

Description

In the Inactive Users module, when the mode is set to REPORT (flag only), users flagged as inactive can never have their status cleared through normal login activity.

The record_activity() method unconditionally skips recording activity for users already considered inactive, but the "Unblock" UI that provides the only way to clear the flag is only available in BLOCK mode. This creates a permanent "Inactive User" badge with no built-in resolution path in REPORT mode.

The fix gates the early return in record_activity() on BLOCK mode only, so that in REPORT mode logging in naturally records activity and clears the inactive flag.

Changelog Description

Fixed

• Fixed a bug where users flagged as inactive in REPORT mode were permanently stuck with the inactive flag after logging back in, because stale last_seen meta was never cleared on login

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

• This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
• This change has relevant unit tests (if applicable).
• This change has relevant documentation additions / updates (if applicable).
• I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

• VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

1. Check out this PR.
2. Set the inactive users module to REPORT mode.
3. Create or use a test user and allow them to become flagged as inactive (i.e., their last_seen meta is older than the inactivity threshold).
4. Verify the user appears in the inactive users report.
5. Log in as the flagged user.
6. Verify that the stale last_seen meta is cleared on login and the user is no longer flagged as inactive.
7. Run the unit tests: phpunit --filter test-inactive-users and verify all tests pass.

[andrea-sdl]

@katag9k what do we gain by cleaning this before it gets set again below? Wouldn't the update_user_meta be enough?

[katag9k]

Good point. I think I may have misinterpreted what @rinatkhaziev was suggesting. This whole thing hooks into set_current_user, so clearing the meta is pointless since it gets set again right after during the login process.

[andrea-sdl]

Thank you so much for this!!! I left a small comment to better understand if I'm missing a piece of the puzzle :)