Add Fees and Net columns to the payout list #11116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Contributor
|
Size Change: +698 B (0%) Total Size: 874 kB
ℹ️ View Unchanged
|
granjacours410-source
approved these changes
Nov 3, 2025
granjacours410-source
left a comment
granjacours410-source
left a comment
There was a problem hiding this comment.
After tampermonkey reseting scripts showing this Line up not East whit so many bugs
mgascam
reviewed
Nov 3, 2025
Contributor
mgascam
left a comment
mgascam
left a comment
There was a problem hiding this comment.
The code changes look good, but I'm not certain this is the right data to surface. Please check my comment for more details, although I haven't dig into the code in detail.
| ), | ||
| }, | ||
| fees: { | ||
| value: formatExportAmount( deposit.fee, deposit.currency ), |
Contributor
There was a problem hiding this comment.
I'm less familiar with deposits, but I'd say that we should surface the total fees paid for every transaction included in the deposit. As it is now, we seem to surface the fee associated with the deposit. In my local (can be wrong) the deposit.fee is always zero but when I click in the row then I see all the transactions, each with their fee. I think those are the fees that we should surface.
Member
Author
There was a problem hiding this comment.
@mgascam so, you mean adding up all the transaction fees related to that specific deposit? Is there somewhere we can get that information? Sorry if I'm missing something obvious.
Member
Author
Member
There was a problem hiding this comment.
the new approach of introducing useDepositsWithFeeData, which literally loop through all deposits in the current deposit list, and each of which will send a REST request to get the transaction summary.
I think it's not efficient in all terms (user experience and our server load). IMHO, the right approach here is introduce new fields for the deposit list response to map with what provided. But this also means more work should be added into the server to support these new fields.
Member
There was a problem hiding this comment.
By using the initial commit in this PR 86c2f2d and this patch in the server By 39915-pb/#diff, the outcome looks good: the first one is instant/manual and the second is automatic:
However, the issue is that it's creating the discrepancy in the view of each one. I think this is something we should also improve, and it's worth having a discussion with designs about this.
| Instant | Automatic |
|---|---|
| No transaction | No fee and percentage |
 |
 |
Contributor
There was a problem hiding this comment.
It seems to be an interesting change, because a payout's net amount isn't always defined by the contained transactions:
- For the instant payout, the merchant enters the amount they want from the available volume. The only fee in this case is the instant payout fee.
- Regular payouts do not incur additional fees, but the net amount depends on:
- Transactions included in the payout and related application fees
- Amounts taken with earlier instant payouts
- Additional charges, such as card reader charges.
Therefore, I agree with @htdat that if we start surfacing fees, we need to do it holistically and highlight what "fee" means in each case, linking the WooPayments documentation where needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WOOPMNT-5359
Changes proposed in this Pull Request
This PR add two columns to the payout history list, Fees and Net.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge