-
Notifications
You must be signed in to change notification settings - Fork 72
chore: update fees docs URL #11156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
chore: update fees docs URL #11156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the WooPayments fees documentation URL from the old path (/fees-and-debits/fees/) to a new simplified path (/fees/), and refactors related code for better maintainability.
- Updated fees documentation URLs across readme.txt and account-fees.tsx
- Simplified URL generation logic by removing redundant constants and helper functions
- Updated interpolation pattern for consistency
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| readme.txt | Updated fees documentation link to new URL path |
| client/utils/account-fees.tsx | Consolidated URL constants, removed redundant helper function, simplified URL generation with template literals, and updated link text interpolation pattern |
| client/utils/tests/snapshots/account-fees.test.tsx.snap | Updated test snapshots to reflect new URL structure |
| changelog/chore-update-account-fees-docs-url | Added changelog entry for this update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +6 B (0%) Total Size: 876 kB
ℹ️ View Unchanged
|
mgascam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes WOOPMNT-5516
Changes proposed in this Pull Request
Updating the account fee URLs to their new location.already tackled by #11151Also, simplifying slightly the
client/utils/account-fees.tsxfile and the URL generation.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge