Include chainId in JWT audience field #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: [email protected] <[email protected]>
v9n
reviewed
Apr 19, 2025
| }, | ||
| } | ||
|
|
||
| if txReceipt != nil { |
There was a problem hiding this comment.
Let move this to another PR. Don't touch this file in this PR. We will only handle auth stuff i n this pr
…ct_write.go changes Co-Authored-By: [email protected] <[email protected]>
chrisli30
force-pushed
the
staging
branch
3 times, most recently
from
7422b32 to
63bc1de
Compare
|
Closing due to inactivity for more than 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
This PR adds the chainId to the common audience field of JWT before returning it to the client and verifies it during authentication.
Changes
GetKeyfunctionverifyAuthto check that the chainId in the audience field matches the network's chainIdLink to Devin run: https://app.devin.ai/sessions/5de0e8606d10474ba62b3d64d3da28f4
Requested by: [email protected]