Skip to content

Fix linting issues in staging branch #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: staging
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix linting issues in staging branch

This PR fixes several linting issues detected by golangci-lint:

  1. Fixed Task struct field access in model/task.go by accessing fields through the embedded Task struct.
  2. Added missing types in composite literals in pkg/erc4337/userop/object.go and pkg/erc4337/preset/builder.go.
  3. Fixed range over constant error in core/taskengine/engine_test.go.
  4. Fixed protojson.Marshal usage with *Task in model/task.go.

Link to Devin run: https://app.devin.ai/sessions/8779c91a69c049c28706e937cb852d29
Requested by: Chris Li ([email protected])

devin-ai-integration bot and others added 11 commits April 5, 2025 00:44
* Fix code formatting with gofmt

Co-Authored-By: Chris Li <[email protected]>

* Fix nil pointer dereference in ContractWriteProcessor.Execute

Co-Authored-By: Chris Li <[email protected]>

* Revert changes to vm_runner_contract_write.go to wait for PR #199

Co-Authored-By: Chris Li <[email protected]>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Chris Li <[email protected]>
* Improve error handling for HTTP status code 0 errors

Co-Authored-By: Chris Li <[email protected]>

* Add unit test for HTTP error handling and fix error message capitalization

Co-Authored-By: Chris Li <[email protected]>

* Fix unused import in vm_runner_rest_test.go

Co-Authored-By: Chris Li <[email protected]>

* Updated the testing instructions in README.md

* Fixed test errors from TestRestRequestErrorHandling

* Added Paymaster contract address to docs/contract.md

* Added fixes for TestContractWriteSimpleReturn case

* Updated error message in operator/operator.go

* Added missing txReceipt fields to vm_runner_contract_write.go and test their existence.

* Updated vm_runner_rest.go to handle status 0

* Revert the capitalization of Errorf messages

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Chris Li <[email protected]>
Co-authored-by: chrisli30 <[email protected]>
…o ms (#207)

* Add backup ability to run with repl console

* add a migration framework, create second -> ms converted

* autoformat code on push

* Use go1.24 in Dockerfile

* fix new grpc format

* add new packages to test

* add new pkg to test run

* fix AI slop

* fix timestamp change

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ds (#208)

* docs: update development.md with improved formatting and REPL command documentation

Co-Authored-By: [email protected] <[email protected]>

* docs: add missing rm and backup commands to development.md

Co-Authored-By: [email protected] <[email protected]>

* docs: update rm command example to use generic prefix

Co-Authored-By: [email protected] <[email protected]>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: [email protected] <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants