-
Notifications
You must be signed in to change notification settings - Fork 64
Fix linting issues in staging branch #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
15
commits into
staging
Choose a base branch
from
devin/1745221299-fix-linting-issues
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix linting issues in staging branch #218
devin-ai-integration
wants to merge
15
commits into
staging
from
devin/1745221299-fix-linting-issues
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix code formatting with gofmt Co-Authored-By: Chris Li <[email protected]> * Fix nil pointer dereference in ContractWriteProcessor.Execute Co-Authored-By: Chris Li <[email protected]> * Revert changes to vm_runner_contract_write.go to wait for PR #199 Co-Authored-By: Chris Li <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chris Li <[email protected]>
* Improve error handling for HTTP status code 0 errors Co-Authored-By: Chris Li <[email protected]> * Add unit test for HTTP error handling and fix error message capitalization Co-Authored-By: Chris Li <[email protected]> * Fix unused import in vm_runner_rest_test.go Co-Authored-By: Chris Li <[email protected]> * Updated the testing instructions in README.md * Fixed test errors from TestRestRequestErrorHandling * Added Paymaster contract address to docs/contract.md * Added fixes for TestContractWriteSimpleReturn case * Updated error message in operator/operator.go * Added missing txReceipt fields to vm_runner_contract_write.go and test their existence. * Updated vm_runner_rest.go to handle status 0 * Revert the capitalization of Errorf messages --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chris Li <[email protected]> Co-authored-by: chrisli30 <[email protected]>
…o ms (#207) * Add backup ability to run with repl console * add a migration framework, create second -> ms converted * autoformat code on push * Use go1.24 in Dockerfile * fix new grpc format * add new packages to test * add new pkg to test run * fix AI slop * fix timestamp change --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ds (#208) * docs: update development.md with improved formatting and REPL command documentation Co-Authored-By: [email protected] <[email protected]> * docs: add missing rm and backup commands to development.md Co-Authored-By: [email protected] <[email protected]> * docs: update rm command example to use generic prefix Co-Authored-By: [email protected] <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: [email protected] <[email protected]>
Signed-off-by: fivecut <[email protected]>
Co-Authored-By: Chris Li <[email protected]>
Co-Authored-By: Chris Li <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Chris Li <[email protected]>
Co-Authored-By: Chris Li <[email protected]>
Co-Authored-By: Chris Li <[email protected]>
…dentials are missing Co-Authored-By: Chris Li <[email protected]>
7422b32
to
63bc1de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix linting issues in staging branch
This PR fixes several linting issues detected by golangci-lint:
Link to Devin run: https://app.devin.ai/sessions/8779c91a69c049c28706e937cb852d29
Requested by: Chris Li ([email protected])