display: support generic wlr-output-management-unstable-v1#1840
Open
ezemtsov wants to merge 1 commit intoAvengeMedia:masterfrom
Open
display: support generic wlr-output-management-unstable-v1#1840ezemtsov wants to merge 1 commit intoAvengeMedia:masterfrom
ezemtsov wants to merge 1 commit intoAvengeMedia:masterfrom
Conversation
The display config UI only applied changes for compositors with a config-file backend (niri, hyprland, dwl). For any other compositor that supports wlr-output-management-unstable-v1 the "Apply Changes" button was silently a no-op. Add WlrOutputService.applyOutputsConfig() as a high-level apply that mirrors the generateOutputsConfig() pattern of the existing services but applies directly via the protocol instead of writing a config file. Route the default case in backendWriteOutputsConfig() to it. This enables using dms-shell as a wayland compositor for emacs wayland manager (ewm).
Collaborator
|
This is good, but the original reason to skip this was because of the potential risk in writing bad settings that could potentially damage displays (idk how possible it is exactly, but might need more oversight). And the secondary issue of persistence, that is the display settings won't be remembered at all. Would it make sense to have some memory and compare + apply settings at DMS startup (when settings are managed this way) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The display config UI only applied changes for compositors with a config-file backend (niri, hyprland, dwl). For any other compositor that supports wlr-output-management-unstable-v1 the "Apply Changes" button was silently a no-op.
Add WlrOutputService.applyOutputsConfig() as a high-level apply that mirrors the generateOutputsConfig() pattern of the existing services but applies directly via the protocol instead of writing a config file. Route the default case in backendWriteOutputsConfig() to it.
This change enables using dms-shell as a wayland compositor for emacs wayland manager (ewm).